refactor(l2): replace sequencer config toml with CLI flags

.github/workflows/main_prover.yaml

@@ -61,11 +61,10 @@ jobs:
           cp configs/prover_client_config_example.toml configs/prover_client_config.toml
           cp configs/sequencer_config_example.toml configs/sequencer_config.toml
 
-          sed -i 's/sp1_deploy_verifier = false/sp1_deploy_verifier = true/' configs/sequencer_config.toml
-          sed -i 's/block_time_ms = 5000/block_time_ms = 12000/' configs/sequencer_config.toml
-          sed -i 's/listen_ip = "127.0.0.1"/listen_ip = "0.0.0.0"/' configs/sequencer_config.toml
-          sed -i 's/dev_mode = true/dev_mode = false/' configs/sequencer_config.toml
-
+          ETHREX_PROOF_COORDINATOR_DEV_MODE=false \
+          ETHREX_PROPOSER_BLOCK_TIME_MS=12000 \
+          ETHREX_PROOF_COORDINATOR_LISTEN_IP=0.0.0.0 \
+          ETHREX_DEPLOYER_PICO_DEPLOY_VERIFIER=true \
           make integration-test-gpu
 
       - name: Ensure admin permissions in _work
@@ -77,6 +76,6 @@ jobs:
         uses: ravsamhq/notify-slack-action@v2
         with:
           status: ${{ job.status }}
-          notify_when: 'failure'
+          notify_when: "failure"
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.ETHREX_L2_SLACK_WEBHOOK }}

.github/workflows/pr-main_l2.yaml

@@ -100,10 +100,8 @@ jobs:
           cd crates/l2
           cp configs/prover_client_config_example.toml configs/prover_client_config.toml
           cp configs/sequencer_config_example.toml configs/sequencer_config.toml
-          sed -i 's/listen_ip = "127.0.0.1"/listen_ip = "0.0.0.0"/' configs/sequencer_config.toml
-          if [ "${{ matrix.validium }}" = "true" ]; then
-            sed -i.bak 's/^validium = false$/validium = true/' configs/sequencer_config.toml && rm configs/sequencer_config.toml.bak
-          fi
+          ETHREX_PROOF_COORDINATOR_LISTEN_IP=0.0.0.0 \
+          ETHREX_COMMITTER_VALIDIUM=${{ matrix.validium }} \
           make integration-test
 
   state-diff-test:
@@ -151,9 +149,7 @@ jobs:
           cd crates/l2
           cp configs/prover_client_config_example.toml configs/prover_client_config.toml
           cp configs/sequencer_config_example.toml configs/sequencer_config.toml
-          sed -i 's/listen_ip = "127.0.0.1"/listen_ip = "0.0.0.0"/' configs/sequencer_config.toml
-
-          make state-diff-test
+          ETHREX_PROOF_COORDINATOR_LISTEN_IP=0.0.0.0 make state-diff-test
 
   # The purpose of this job is to add it as a required check in GitHub so that we don't have to add every individual job as a required check
   all-tests:

cmd/ethrex/initializers.rs

@@ -30,11 +30,7 @@ use tracing_subscriber::{filter::Directive, EnvFilter, FmtSubscriber};
 #[cfg(feature = "l2")]
 use crate::l2::L2Options;
 #[cfg(feature = "l2")]
-use ::{
-    ethrex_common::Address,
-    ethrex_l2::utils::config::{read_env_file_by_config, ConfigMode},
-    secp256k1::SecretKey,
-};
+use ::{ethrex_common::Address, secp256k1::SecretKey};
 
 #[cfg(feature = "based")]
 use crate::l2::BasedOptions;
@@ -396,15 +392,5 @@ pub fn get_sponsor_pk(opts: &L2Options) -> SecretKey {
     if let Some(pk) = opts.sponsor_private_key {
         return pk;
     }
-
-    warn!("Sponsor private key not provided. Trying to read from the .env file.");
-
-    if let Err(e) = read_env_file_by_config(ConfigMode::Sequencer) {
-        panic!("Failed to read .env file: {e}");
-    }
-    let pk = std::env::var("L1_WATCHER_L2_PROPOSER_PRIVATE_KEY").unwrap_or_default();
-    pk.strip_prefix("0x")
-        .unwrap_or(&pk)
-        .parse::<SecretKey>()
-        .expect("Failed to parse a secret key to sponsor transactions")
+    opts.sequencer_opts.watcher_opts.l2_proposer_private_key
 }

cmd/ethrex/l2.rs → cmd/ethrex/l2/command.rs

@@ -1,14 +1,16 @@
 use crate::{
-    cli::{self as ethrex_cli, Options},
+    cli::{self as ethrex_cli, Options as NodeOptions},
     initializers::{
         get_local_p2p_node, get_network, get_signer, init_blockchain, init_metrics, init_network,
         init_rpc_api, init_store,
     },
-    utils::{self, set_datadir, store_known_peers},
+    l2::options::Options,
+    utils::{set_datadir, store_known_peers},
     DEFAULT_L2_DATADIR,
 };
-use clap::{Parser, Subcommand};
+use clap::Subcommand;
 use ethrex_common::{Address, U256};
+use ethrex_l2::SequencerConfig;
 use ethrex_p2p::network::peer_table;
 use ethrex_rpc::{
     clients::{beacon::BeaconClient, eth::BlockByNumber},
@@ -17,7 +19,6 @@ use ethrex_rpc::{
 use eyre::OptionExt;
 use keccak_hash::keccak;
 use reqwest::Url;
-use secp256k1::SecretKey;
 use std::{fs::create_dir_all, future::IntoFuture, path::PathBuf, time::Duration};
 use tokio_util::task::TaskTracker;
 use tracing::info;
@@ -28,7 +29,7 @@ pub enum Command {
     #[clap(about = "Initialize an ethrex L2 node", visible_alias = "i")]
     Init {
         #[command(flatten)]
-        opts: L2Options,
+        opts: Options,
     },
     #[clap(name = "removedb", about = "Remove the database", visible_aliases = ["rm", "clean"])]
     RemoveDB {
@@ -54,68 +55,6 @@ pub enum Command {
     },
 }
 
-#[derive(Parser, Default)]
-pub struct L2Options {
-    #[command(flatten)]
-    pub node_opts: Options,
-    #[arg(
-        long = "sponsorable-addresses",
-        value_name = "SPONSORABLE_ADDRESSES_PATH",
-        help = "Path to a file containing addresses of contracts to which ethrex_SendTransaction should sponsor txs",
-        help_heading = "L2 options"
-    )]
-    pub sponsorable_addresses_file_path: Option<String>,
-    #[arg(long, value_parser = utils::parse_private_key, env = "SPONSOR_PRIVATE_KEY", help = "The private key of ethrex L2 transactions sponsor.", help_heading = "L2 options")]
-    pub sponsor_private_key: Option<SecretKey>,
-    #[cfg(feature = "based")]
-    #[command(flatten)]
-    pub based_opts: BasedOptions,
-}
-
-#[cfg(feature = "based")]
-#[derive(Parser, Default)]
-pub struct BasedOptions {
-    #[arg(
-        long = "gateway.addr",
-        default_value = "0.0.0.0",
-        value_name = "GATEWAY_ADDRESS",
-        env = "GATEWAY_ADDRESS",
-        help_heading = "Based options"
-    )]
-    pub gateway_addr: String,
-    #[arg(
-        long = "gateway.eth_port",
-        default_value = "8546",
-        value_name = "GATEWAY_ETH_PORT",
-        env = "GATEWAY_ETH_PORT",
-        help_heading = "Based options"
-    )]
-    pub gateway_eth_port: String,
-    #[arg(
-        long = "gateway.auth_port",
-        default_value = "8553",
-        value_name = "GATEWAY_AUTH_PORT",
-        env = "GATEWAY_AUTH_PORT",
-        help_heading = "Based options"
-    )]
-    pub gateway_auth_port: String,
-    #[arg(
-        long = "gateway.jwtsecret",
-        default_value = "jwt.hex",
-        value_name = "GATEWAY_JWTSECRET_PATH",
-        env = "GATEWAY_JWTSECRET_PATH",
-        help_heading = "Based options"
-    )]
-    pub gateway_jwtsecret: String,
-    #[arg(
-        long = "gateway.pubkey",
-        value_name = "GATEWAY_PUBKEY",
-        env = "GATEWAY_PUBKEY",
-        help_heading = "Based options"
-    )]
-    pub gateway_pubkey: String,
-}
-
 impl Command {
     pub async fn run(self) -> eyre::Result<()> {
         match self {
@@ -174,7 +113,10 @@ impl Command {
                     info!("P2P is disabled");
                 }
 
-                let l2_sequencer = ethrex_l2::start_l2(store, blockchain).into_future();
+                let l2_sequencer_cfg = SequencerConfig::from(opts.sequencer_opts);
+
+                let l2_sequencer =
+                    ethrex_l2::start_l2(store, blockchain, l2_sequencer_cfg).into_future();
 
                 tracker.spawn(l2_sequencer);
 
@@ -193,7 +135,7 @@ impl Command {
             Self::RemoveDB { datadir, force } => {
                 Box::pin(async {
                     ethrex_cli::Subcommand::RemoveDB { datadir, force }
-                        .run(&Options::default()) // This is not used by the RemoveDB command.
+                        .run(&NodeOptions::default()) // This is not used by the RemoveDB command.
                         .await
                 })
                 .await?

cmd/ethrex/l2/mod.rs

@@ -0,0 +1,10 @@
+pub mod command;
+pub mod options;
+
+pub use command::Command;
+#[cfg(feature = "based")]
+pub use options::BasedOptions;
+pub use options::{
+    CommitterOptions, DeployerOptions, EthOptions, Options as L2Options, ProofCoordinatorOptions,
+    ProposerOptions, SequencerOptions, WatcherOptions,
+};