Skip to content

docs(p2p): Update network docs #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 8, 2025
Merged

docs(p2p): Update network docs #2613

merged 9 commits into from
May 8, 2025

Conversation

Mechanix97
Copy link
Contributor

Motivation

The network example was outdated and it was not working

Description

Modified the commands to use diferents datadirs in order to generate distincts node_id

Closes #2608

@github-actions GitHub Actions
Copy link

Lines of code report

Total lines added: 4
Total lines removed: 3
Total lines changed: 7

Detailed view 
+----------------------------------------------------+-------+------+
| File                                               | Lines | Diff |
+----------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/sync_manager.rs       | 130   | +3   |
+----------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/engine/fork_choice.rs | 390   | -3   |
+----------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/engine/payload.rs     | 699   | +1   |
+----------------------------------------------------+-------+------+

@Mechanix97 Mechanix97 self-assigned this Apr 25, 2025
@mpaulucci mpaulucci changed the title Docs(p2p): Update network docs docs(p2p): Update network docs Apr 28, 2025
@Mechanix97 Mechanix97 marked this pull request as ready for review April 28, 2025 14:34
@Mechanix97 Mechanix97 requested a review from a team as a code owner April 28, 2025 14:34
tomip01
tomip01 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@tomip01 tomip01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Just two comments

@Mechanix97 Mechanix97 added docs Improvements or additions to documentation p2p Issues related to p2p network labels Apr 28, 2025
Mechanix97 and others added 2 commits April 28, 2025 16:09
@Mechanix97 @tomip01
Update crates/networking/docs/Network.md
e8ca076 
Co-authored-by: Tomás Paradelo <112426153+tomip01@users.noreply.github.com>
@Mechanix97 @tomip01
Update crates/networking/docs/Network.md
44b0836 
Co-authored-by: Tomás Paradelo <112426153+tomip01@users.noreply.github.com>
mpaulucci
mpaulucci approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator

@mpaulucci mpaulucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mpaulucci mpaulucci added this pull request to the merge queue May 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 7, 2025
@Mechanix97 Mechanix97 enabled auto-merge May 7, 2025 16:06
@Mechanix97 Mechanix97 added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit 435107b May 8, 2025
20 checks passed
@Mechanix97 Mechanix97 deleted the docs/update-p2p-network-example branch May 8, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpaulucci mpaulucci mpaulucci approved these changes

@tomip01 tomip01 tomip01 approved these changes

Assignees

@Mechanix97 Mechanix97

Labels
docs Improvements or additions to documentation p2p Issues related to p2p network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2P discovery not working in localhost
3 participants
@Mechanix97 @mpaulucci @tomip01