refactor(core): cleanup import blocks bench code #2631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
mpaulucci
force-pushed
the
cleanup-import-blocks-bench
branch
from
061aee2 to
1b8424f
Compare
mpaulucci
changed the title
mpaulucci
force-pushed
the
cleanup-import-blocks-bench
branch
from
1b8424f to
3df3d2a
Compare
jrchatruc
approved these changes
May 8, 2025
JereSalo
approved these changes
May 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
fmoletta
pushed a commit
that referenced
this pull request
May 15, 2025
**Description** - Moved import blocks benchmark from the top folder to /cmd/ethrex - Updated evm in benchmark to use the default one - Renamed generic `criterion_benchmark` to `import_block_benchmark` - Renamed confusing `genesis-l2-ci.json` to `genesis-perf-ci.json` since it's not really related to l2. - Removed deprecated flamegraph script --------- Co-authored-by: Javier Chatruc <jrchatruc@gmail.com>
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Description** - Moved import blocks benchmark from the top folder to /cmd/ethrex - Updated evm in benchmark to use the default one - Renamed generic `criterion_benchmark` to `import_block_benchmark` - Renamed confusing `genesis-l2-ci.json` to `genesis-perf-ci.json` since it's not really related to l2. - Removed deprecated flamegraph script --------- Co-authored-by: Javier Chatruc <jrchatruc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
criterion_benchmarktoimport_block_benchmarkgenesis-l2-ci.jsontogenesis-perf-ci.jsonsince it's not really related to l2.