fix(l1, l2): make levm default in enum #2632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
jrchatruc
approved these changes
May 8, 2025
rodrigo-o
approved these changes
May 8, 2025
JereSalo
approved these changes
May 8, 2025
This reverts commit 5b076a7.
mpaulucci
commented
May 12, 2025
| @@ -632,39 +632,6 @@ mod tests { | |||
| assert_eq!(response.to_string(), expected_response.to_string()); | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
There was a problem hiding this comment.
Removing since this test is outdated and is a copy of the one with have in hive
fmoletta
pushed a commit
that referenced
this pull request
May 15, 2025
**Motivation** Just set the default vm in a single place **Description** - Even though the cli changed to `levm`, we still had `revm` as the default enum --------- Co-authored-by: Javier Chatruc <jrchatruc@gmail.com> Co-authored-by: Javier Rodríguez Chatruc <49622509+jrchatruc@users.noreply.github.com>
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** Just set the default vm in a single place **Description** - Even though the cli changed to `levm`, we still had `revm` as the default enum --------- Co-authored-by: Javier Chatruc <jrchatruc@gmail.com> Co-authored-by: Javier Rodríguez Chatruc <49622509+jrchatruc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Just set the default vm in a single place
Description
levm, we still hadrevmas the default enum