Skip to content

feat(l1): don't log an error if we have no node config file when reading known peers #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fmoletta
Copy link
Contributor

Motivation
We shouldn't emit a warning if we have no node config files where to read known peers from. We should log an error if we get an actual error while reading from an existing node config file

Description

  • Don't emit a warning if we have no node config file when reading known peers

Closes #3908

@github-actions github-actions bot added the L1 Ethereum client label Aug 21, 2025
Copy link

Lines of code report

Total lines added: 7
Total lines removed: 1
Total lines changed: 8

Detailed view
+-----------------------------------+-------+------+
| File                              | Lines | Diff |
+-----------------------------------+-------+------+
| ethrex/cmd/ethrex/initializers.rs | 375   | -1   |
+-----------------------------------+-------+------+
| ethrex/cmd/ethrex/utils.rs        | 171   | +7   |
+-----------------------------------+-------+------+

@fmoletta fmoletta marked this pull request as ready for review August 21, 2025 21:42
@fmoletta fmoletta requested a review from a team as a code owner August 21, 2025 21:42
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L1 Ethereum client
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

Ethrex should not log an error if the peers file is not found
1 participant