chore(l1): use local tag for ethrex images for local hive and kurtosis
#4132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates Docker image tags to use explicit local tags instead of latest for locally built ethrex images. This change prevents accidental usage of outdated remote images when developers intend to use their locally built versions.
Key changes:
- Replace
ethrex:latestwithethrex:localin network configuration files - Update Docker build commands and references to use the
localtag - Remove deprecated hive client configuration files and consolidate hive setup
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| fixtures/networks/network_params_ethrex_only.yaml | Updated ethrex image tag from latest to local |
| fixtures/networks/network_params_client_comparision.yaml | Updated ethrex image tags from latest to local for both participants |
| fixtures/networks/network_params.yaml | Updated ethrex image tag from latest to local |
| fixtures/network/hive_clients/ethrex_local.yml | Removed deprecated hive client configuration file |
| fixtures/network/hive_clients/ethrex_git.yml | Removed deprecated hive client configuration file |
| fixtures/network/hive_clients/ethrex.yml | Removed deprecated hive client configuration file |
| Makefile | Updated Docker build command to tag with local, fixed config file path, and updated hive client file reference |
Comments suppressed due to low confidence (1)
fixtures/networks/network_params_client_comparision.yaml:1
- The filename contains a typo: 'comparision' should be 'comparison'.
participants:
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mpaulucci
commented
Aug 22, 2025
| @@ -1,4 +0,0 @@ | |||
| - client: ethrex | |||
There was a problem hiding this comment.
This is not supported by us
ManuelBilbao
approved these changes
Aug 22, 2025
fmoletta
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make it explicit that we're using a locally build version of ethrex. Decouple CI from local use of docker images
Description
Since
latestis the default tag if none is specified, we had bugs in the past where we were accidentally using an old version of ethrex instead of the locally build one. Lets make it explicit that we're using a local version by using thelocaltag instead oflatest.