-
Notifications
You must be signed in to change notification settings - Fork 0
feat: first itereation of MVP #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
damiramirez
wants to merge
24
commits into
main
Choose a base branch
from
feat/db
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a first implementation of EthrexDB
file_manager.rs
: Handles file I/O and memory mappingserialization.rs
: Converts between MPT nodes and binary format using a 2-node system (Branch + Extend)db.rs
: Main API providingcommit()
,get()
, androot()
operationsIn this first iteration, the DB depends on a root node, so I'm using
ethrex::InMemoryTrieDB
to handle the inserts. Once we finish adding values to the tree, we can calldb.commit(&root_node)
to serialize the entire MPT to a file.Since we're using structs/function from Ethrex, the trie and RLP logic has been copied from the Ethrex repository. You can find this code under
src/trie
andsrc/rlp
.Benchmarking and Profiling
To run a benchmark comparing this new implementation against libmdbx (as we do in Ethrex), run:
To profile using Samply, run:
File Format
Implements a simple append-only file for storing complete MPT
Limitations of this iteration - Next steps
NodeRef::Hash
references (supports onlyNodeRef::Node
).