Skip to content

refactor: remove Default contraint in merkle tree trait #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MarcosNicolau
Copy link
Contributor

Remove Default contraint in IsMerkleTreeBackend

Description

Previously, the IsMerkleTreeBackend trait required types to implement the Default trait. However, Default is no longer used in the current Merkle tree construction logic.

Requiring Default can be unnecessarily restrictive, especially in codebases where implementing it is non-trivial. This change simplifies the trait by removing the Default constraint, making it easier to implement custom backends.

Type of change

  • Refactor

Checklist

  • Linked to Github Issue
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run

@MarcosNicolau MarcosNicolau requested a review from a team as a code owner May 5, 2025 17:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.06%. Comparing base (7a336ca) to head (c44a810).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1004   +/-   ##
=======================================
  Coverage   72.06%   72.06%           
=======================================
  Files         160      160           
  Lines       35145    35145           
=======================================
  Hits        25327    25327           
  Misses       9818     9818           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MauroToscano MauroToscano added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit 5f8f2cf May 5, 2025
8 checks passed
@MauroToscano MauroToscano deleted the refactor/remove-default-constraint-in-merkle-tree-trait branch May 5, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants