Remove Metal feature #993
Merged
Remove Metal feature #993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
==========================================
- Coverage 72.02% 72.00% -0.02%
==========================================
Files 159 159
Lines 34895 34867 -28
==========================================
- Hits 25133 25107 -26
+ Misses 9762 9760 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
diegokingston
approved these changes
Apr 4, 2025
Oppen
approved these changes
Apr 4, 2025
erhant
pushed a commit
to erhant/lambdaworks
that referenced
this pull request
Apr 5, 2025
* rm all metal features * fix clippy * fix attribute * fix another attribute
MauroToscano
pushed a commit
that referenced
this pull request
Apr 7, 2025
* migrate fixes from other PR, todo tutorial guide fixes * update tutorial docs as well * update readme * fix lint * fix export witness.json doc * Remove Metal feature (#993) * rm all metal features * fix clippy * fix attribute * fix another attribute * Update Readme (#987) * update kzg Readme * KZG: make sure example is ok * Add Readme for Merkle Tree * Add Readme for Circle * fix circle docs * fix circle readme * fix typo, remove unused test and fix markdown style * changes in circle readme * fix circle readme * fix clippy * fix clippy spaces --------- Co-authored-by: Nicole <nicole.graus@lambdaclass.com> Co-authored-by: Joaquin Carletti <joaquin.carletti@lambdaclass.com> Co-authored-by: Diego K <43053772+diegokingston@users.noreply.github.com> --------- Co-authored-by: Joaquin Carletti <56092489+ColoCarletti@users.noreply.github.com> Co-authored-by: jotabulacios <45471455+jotabulacios@users.noreply.github.com> Co-authored-by: Nicole <nicole.graus@lambdaclass.com> Co-authored-by: Joaquin Carletti <joaquin.carletti@lambdaclass.com> Co-authored-by: Diego K <43053772+diegokingston@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Metal feature
The implementation was outdated and not working as intended.