feat(CLI): add multicall support
#2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lima-limon-inc
force-pushed
the
fabrizioorsi-cli-multicall
branch
2 times, most recently
from
a23decc to
f498f8c
Compare
Implement slicing of the word constants
* doc: update miden-assmbly documentation, use it as doctests Fixes 0xMiden#2064 * doc: convert Readme GH-flavored md -> Rustdoc
chore: update miden-crypto to v0.16
igaray
approved these changes
Aug 18, 2025
feat(host): make `get_mast_forest` async again
lima-limon-inc
force-pushed
the
fabrizioorsi-cli-multicall
branch
from
f498f8c to
00bc79c
Compare
Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
lima-limon-inc
force-pushed
the
fabrizioorsi-cli-multicall
branch
from
00bc79c to
b16f18d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR makes the VM's CLI multicall compatible. With this, the CLI is now aware of whether it is being called under the
miden-vmname or a different one. This is used in midenup's invocation of the vm, which is done under themiden vmcommand.The
Clistruct now stores this information, in theexternalfield; however, this information is not currently being used.Multicall awareness is being tracked in this issue (0xMiden/midenup#70) in midenup.
Checklist before requesting a review
nextaccording to naming convention.