Skip to content

Conversation

juan518munoz
Copy link

What ❔

Implement blob size limit for Eigen DA client

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

Copy link

@gianbelinche gianbelinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add also a test for remote client for blob size limit

@juan518munoz
Copy link
Author

Maybe add also a test for remote client for blob size limit

The blob size check is done prior to either a memstore or remote dispersal, so a single test should cover both cases.

Copy link

@gianbelinche gianbelinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from eigen-client-memstore to eigen-client-extra-features November 5, 2024 16:10
@juan518munoz juan518munoz merged commit b164870 into eigen-client-extra-features Nov 5, 2024
13 of 24 checks passed
@juan518munoz juan518munoz deleted the eigen-client-blob-size-limit branch November 5, 2024 17:32
github-merge-queue bot pushed a commit to matter-labs/zksync-era that referenced this pull request Feb 20, 2025
## What ❔

### Note:
Related era-contract PR:
matter-labs/era-contracts#1233

This PR adds extra functionality to the eigen client:

- [x] Non authenticated blob dispersal
lambdaclass#318
- [x] RLP encoding for blobs
lambdaclass#319
- [x] Get inclusion data
lambdaclass#324
- [x] Memstore lambdaclass#321
- [x] Blob size limit lambdaclass#325
- [x] Soft confirmations
lambdaclass#322
- [x] Verification logic
lambdaclass#326
- [x] EigenDA Documentation
lambdaclass#327

## Why ❔

These features are needed to have a full featured client and to have the
same features as when communicating with the EigenDA proxy.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.

---------

Co-authored-by: Juan Munoz <juanmunoz890@gmail.com>
Co-authored-by: Gianbelinche <39842759+gianbelinche@users.noreply.github.com>
Co-authored-by: juan518munoz <62400508+juan518munoz@users.noreply.github.com>
zkzoomer pushed a commit to matter-labs/zksync-era that referenced this pull request Jun 21, 2025
## What ❔

### Note:
Related era-contract PR:
matter-labs/era-contracts#1233

This PR adds extra functionality to the eigen client:

- [x] Non authenticated blob dispersal
lambdaclass#318
- [x] RLP encoding for blobs
lambdaclass#319
- [x] Get inclusion data
lambdaclass#324
- [x] Memstore lambdaclass#321
- [x] Blob size limit lambdaclass#325
- [x] Soft confirmations
lambdaclass#322
- [x] Verification logic
lambdaclass#326
- [x] EigenDA Documentation
lambdaclass#327

## Why ❔

These features are needed to have a full featured client and to have the
same features as when communicating with the EigenDA proxy.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.

---------

Co-authored-by: Juan Munoz <juanmunoz890@gmail.com>
Co-authored-by: Gianbelinche <39842759+gianbelinche@users.noreply.github.com>
Co-authored-by: juan518munoz <62400508+juan518munoz@users.noreply.github.com>
dutterbutter pushed a commit to dutterbutter/zkstack-cli that referenced this pull request Jul 3, 2025
## What ❔

### Note:
Related era-contract PR:
matter-labs/era-contracts#1233

This PR adds extra functionality to the eigen client:

- [x] Non authenticated blob dispersal
lambdaclass/zksync-era#318
- [x] RLP encoding for blobs
lambdaclass/zksync-era#319
- [x] Get inclusion data
lambdaclass/zksync-era#324
- [x] Memstore lambdaclass/zksync-era#321
- [x] Blob size limit lambdaclass/zksync-era#325
- [x] Soft confirmations
lambdaclass/zksync-era#322
- [x] Verification logic
lambdaclass/zksync-era#326
- [x] EigenDA Documentation
lambdaclass/zksync-era#327

## Why ❔

These features are needed to have a full featured client and to have the
same features as when communicating with the EigenDA proxy.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.

---------

Co-authored-by: Juan Munoz <juanmunoz890@gmail.com>
Co-authored-by: Gianbelinche <39842759+gianbelinche@users.noreply.github.com>
Co-authored-by: juan518munoz <62400508+juan518munoz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants