-
Notifications
You must be signed in to change notification settings - Fork 1
feat(eigen-client-extra-features): blob size limit #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eigen-client-extra-features): blob size limit #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add also a test for remote client for blob size limit
The blob size check is done prior to either a memstore or remote dispersal, so a single test should cover both cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b164870
into
eigen-client-extra-features
## What ❔ ### Note: Related era-contract PR: matter-labs/era-contracts#1233 This PR adds extra functionality to the eigen client: - [x] Non authenticated blob dispersal lambdaclass#318 - [x] RLP encoding for blobs lambdaclass#319 - [x] Get inclusion data lambdaclass#324 - [x] Memstore lambdaclass#321 - [x] Blob size limit lambdaclass#325 - [x] Soft confirmations lambdaclass#322 - [x] Verification logic lambdaclass#326 - [x] EigenDA Documentation lambdaclass#327 ## Why ❔ These features are needed to have a full featured client and to have the same features as when communicating with the EigenDA proxy. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`. --------- Co-authored-by: Juan Munoz <juanmunoz890@gmail.com> Co-authored-by: Gianbelinche <39842759+gianbelinche@users.noreply.github.com> Co-authored-by: juan518munoz <62400508+juan518munoz@users.noreply.github.com>
## What ❔ ### Note: Related era-contract PR: matter-labs/era-contracts#1233 This PR adds extra functionality to the eigen client: - [x] Non authenticated blob dispersal lambdaclass#318 - [x] RLP encoding for blobs lambdaclass#319 - [x] Get inclusion data lambdaclass#324 - [x] Memstore lambdaclass#321 - [x] Blob size limit lambdaclass#325 - [x] Soft confirmations lambdaclass#322 - [x] Verification logic lambdaclass#326 - [x] EigenDA Documentation lambdaclass#327 ## Why ❔ These features are needed to have a full featured client and to have the same features as when communicating with the EigenDA proxy. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`. --------- Co-authored-by: Juan Munoz <juanmunoz890@gmail.com> Co-authored-by: Gianbelinche <39842759+gianbelinche@users.noreply.github.com> Co-authored-by: juan518munoz <62400508+juan518munoz@users.noreply.github.com>
## What ❔ ### Note: Related era-contract PR: matter-labs/era-contracts#1233 This PR adds extra functionality to the eigen client: - [x] Non authenticated blob dispersal lambdaclass/zksync-era#318 - [x] RLP encoding for blobs lambdaclass/zksync-era#319 - [x] Get inclusion data lambdaclass/zksync-era#324 - [x] Memstore lambdaclass/zksync-era#321 - [x] Blob size limit lambdaclass/zksync-era#325 - [x] Soft confirmations lambdaclass/zksync-era#322 - [x] Verification logic lambdaclass/zksync-era#326 - [x] EigenDA Documentation lambdaclass/zksync-era#327 ## Why ❔ These features are needed to have a full featured client and to have the same features as when communicating with the EigenDA proxy. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`. --------- Co-authored-by: Juan Munoz <juanmunoz890@gmail.com> Co-authored-by: Gianbelinche <39842759+gianbelinche@users.noreply.github.com> Co-authored-by: juan518munoz <62400508+juan518munoz@users.noreply.github.com>
What ❔
Implement blob size limit for Eigen DA client
Checklist
zkstack dev fmt
andzkstack dev lint
.