feat(eigen-client-extra-features): Verifier #326

gianbelinche · 2024-11-04T18:26:03Z

What ❔

This PR implements verifier for EigenDA

Since config was changed, recompile zkstack:
cargo install --path zkstack_cli/crates/zkstack --force --locked

Why ❔

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.
Code has been formatted via zkstack dev fmt and zkstack dev lint.

…-dispersal

…tore

core/node/da_clients/src/eigen/eigendaservicemanager.rs

juan518munoz

LGTM. Be sure to remove all unused imports before merging!

core/lib/config/src/configs/da_client/eigen.rs

juanbono · 2024-11-04T20:31:32Z

core/node/da_clients/src/eigen/verifier.rs

+    pub path_to_points: String,
+}
+
+#[derive(Debug, Clone)]


can you add some docs to this struct?

juanbono · 2024-11-04T20:31:42Z

core/node/da_clients/src/eigen/verifier.rs

+        })
+    }
+
+    fn commit(&self, blob: Vec<u8>) -> Result<G1Affine, VerificationError> {


juanbono · 2024-11-04T20:32:02Z

core/node/da_clients/src/eigen/verifier.rs

+        Ok(())
+    }
+
+    pub async fn verify_certificate(&self, cert: BlobInfo) -> Result<(), VerificationError> {


juanbono

Add docs

gianbelinche · 2024-11-04T20:56:43Z

Add docs

Done

anupsv · 2024-11-05T05:51:57Z

core/node/da_clients/src/eigen/sdk.rs

+        let blob_info = blob_info::BlobInfo::try_from(blob_info)
+            .map_err(|e| anyhow::anyhow!("Failed to convert blob info: {}", e))?;
+        self.verifier
+            .verify_commitment(blob_info.blob_header.commitment.clone(), data)


In this code, I was looking at this file. Where does eigenda fit in the match (self.mode, self.pubdata_da) result ?

To clarify, is this computing the commitment locally to see if the DA has computed the same commitment ?

We fit in (L1BatchCommitmentMode::Validium, PubdataSendingMode::Custom)
The verifier.verifyCommitment function is the one that generates a commitment based on the blob and compares it to the one given by EigenDA.
The code you were looking at is the one that defines what would be sent to the L1, once we make the PR with full M0, that part will send the EigenDA commitment.

anupsv · 2024-11-05T05:58:07Z

core/node/da_clients/src/eigen/verifier.rs

+            &format!("{}{}", cfg.path_to_points, "/g1.point"),
+            "",
+            &format!("{}{}", cfg.path_to_points, "/g2.point.powerOf2"),
+            268435456, // 2 ^ 32


small correction, its 2 ^ 28

anupsv · 2024-11-05T06:05:16Z

core/node/da_clients/src/eigen/verifier.rs

+        let expected_commitment = G1Affine::new_unchecked(
+            Fq::from(num_bigint::BigUint::from_bytes_be(&expected_commitment.x)),
+            Fq::from(num_bigint::BigUint::from_bytes_be(&expected_commitment.y)),
+        );


We should add a isInSubgroup and IsOnCurve checks. Good to catch it even though DA also does it on its end.

anupsv · 2024-11-05T06:09:45Z

core/node/da_clients/src/eigen/verifier.rs

+    ) -> Result<Vec<u8>, VerificationError> {
+        let mut index = index;
+        if proof.len() == 0 || proof.len() % 32 != 0 {
+            return Err(VerificationError::WrongProof);


Would be good to differentiate the errors since the VerificationError::WrongProof is used in many places.

juanbono

LGTM

## What ❔ ### Note: Related era-contract PR: matter-labs/era-contracts#1233 This PR adds extra functionality to the eigen client: - [x] Non authenticated blob dispersal lambdaclass#318 - [x] RLP encoding for blobs lambdaclass#319 - [x] Get inclusion data lambdaclass#324 - [x] Memstore lambdaclass#321 - [x] Blob size limit lambdaclass#325 - [x] Soft confirmations lambdaclass#322 - [x] Verification logic lambdaclass#326 - [x] EigenDA Documentation lambdaclass#327 ## Why ❔ These features are needed to have a full featured client and to have the same features as when communicating with the EigenDA proxy. ## Checklist   - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`. --------- Co-authored-by: Juan Munoz <juanmunoz890@gmail.com> Co-authored-by: Gianbelinche <39842759+gianbelinche@users.noreply.github.com> Co-authored-by: juan518munoz <62400508+juan518munoz@users.noreply.github.com>

## What ❔ ### Note: Related era-contract PR: matter-labs/era-contracts#1233 This PR adds extra functionality to the eigen client: - [x] Non authenticated blob dispersal lambdaclass/zksync-era#318 - [x] RLP encoding for blobs lambdaclass/zksync-era#319 - [x] Get inclusion data lambdaclass/zksync-era#324 - [x] Memstore lambdaclass/zksync-era#321 - [x] Blob size limit lambdaclass/zksync-era#325 - [x] Soft confirmations lambdaclass/zksync-era#322 - [x] Verification logic lambdaclass/zksync-era#326 - [x] EigenDA Documentation lambdaclass/zksync-era#327 ## Why ❔ These features are needed to have a full featured client and to have the same features as when communicating with the EigenDA proxy. ## Checklist   - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`. --------- Co-authored-by: Juan Munoz <juanmunoz890@gmail.com> Co-authored-by: Gianbelinche <39842759+gianbelinche@users.noreply.github.com> Co-authored-by: juan518munoz <62400508+juan518munoz@users.noreply.github.com>

juan518munoz and others added 16 commits October 31, 2024 17:36

initial commit

226834f

Merge branch 'eigen-client-extra-features' into eigen-client-non-auth…

27413ac

…-dispersal

Merge branch 'eigen-client-extra-features' into eigen-client-non-auth…

0dd2289

…-dispersal

Add tests

7f5d01e

Add memstore

ab03654

Add assert to tests

c565e84

Merge branch 'eigen-client-non-auth-dispersal' into eigen-client-mems…

f15932c

…tore

Add rest of memstore

dc5b721

Address pr comments

46838fc

Merge branch 'eigen-client-extra-features' into eigen-client-memstore

d450f8a

Remove to retriable error

ec1a65a

Merge branch 'eigen-client-extra-features' into eigen-client-memstore

7864534

Fix conflicts

edafcff

Add verifier

64226d8

Fix verifier

f75bbad

Add path to points to config

862329b

github-actions bot added the external-contribution label Nov 4, 2024

Merge branch 'eigen-client-extra-features' into eigen-client-memstore

f892e99

juan518munoz mentioned this pull request Nov 4, 2024

feat(main): add eigen client extra features #317

Closed

12 tasks

gianbelinche added 3 commits November 4, 2024 15:39

Merge branch 'eigen-client-memstore' into eigen-client-verifier

be8c975

Fix typo

794bef8

Fix eigenda env test

1c1bc02

juan518munoz reviewed Nov 4, 2024

View reviewed changes

core/node/da_clients/src/eigen/eigendaservicemanager.rs Outdated Show resolved Hide resolved

gianbelinche added 2 commits November 4, 2024 16:15

Fix verifier test

6b463d3

Move eigendaservicemanager to generated

7f94fed

juan518munoz approved these changes Nov 4, 2024

View reviewed changes

Remove unneeded imports

a1e2028

juanbono reviewed Nov 4, 2024

View reviewed changes

core/lib/config/src/configs/da_client/eigen.rs Show resolved Hide resolved

juanbono reviewed Nov 4, 2024

View reviewed changes

juanbono requested changes Nov 4, 2024

View reviewed changes

Document verifier

fa1a6a4

anupsv reviewed Nov 5, 2024

View reviewed changes

gianbelinche added 2 commits November 5, 2024 10:06

Modify errors

15ceab3

Address comments

db0f14e

Base automatically changed from eigen-client-memstore to eigen-client-extra-features November 5, 2024 16:10

gianbelinche added 2 commits November 5, 2024 15:08

Merge branch 'eigen-client-extra-features' into eigen-client-verifier

ff490f9

Fix conflicts

a0a044a

juanbono approved these changes Nov 5, 2024

View reviewed changes

gianbelinche merged commit 9c06b40 into eigen-client-extra-features Nov 5, 2024
12 of 24 checks passed

gianbelinche deleted the eigen-client-verifier branch November 5, 2024 19:11

juanbono mentioned this pull request Nov 8, 2024

feat(eigenda): implement eigenDA client remaining features matter-labs/zksync-era#3243

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(eigen-client-extra-features): Verifier #326

feat(eigen-client-extra-features): Verifier #326

Uh oh!

gianbelinche commented Nov 4, 2024

Uh oh!

Uh oh!

juan518munoz left a comment

Uh oh!

Uh oh!

juanbono Nov 4, 2024

Uh oh!

juanbono Nov 4, 2024

Uh oh!

juanbono Nov 4, 2024

Uh oh!

juanbono left a comment

Uh oh!

gianbelinche commented Nov 4, 2024

Uh oh!

anupsv Nov 5, 2024

Uh oh!

anupsv Nov 5, 2024

Uh oh!

gianbelinche Nov 5, 2024

Uh oh!

anupsv Nov 5, 2024

Uh oh!

anupsv Nov 5, 2024 •

edited

Loading

Uh oh!

anupsv Nov 5, 2024

Uh oh!

juanbono left a comment

Uh oh!

Uh oh!

Uh oh!

feat(eigen-client-extra-features): Verifier #326

feat(eigen-client-extra-features): Verifier #326

Uh oh!

Conversation

gianbelinche commented Nov 4, 2024

What ❔

Why ❔

Checklist

Uh oh!

Uh oh!

juan518munoz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juanbono left a comment

Choose a reason for hiding this comment

Uh oh!

gianbelinche commented Nov 4, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anupsv Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juanbono left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

anupsv Nov 5, 2024 •

edited

Loading