Skip to content

Fix: Rename eigenda client to eigen #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 5, 2025
Merged

Fix: Rename eigenda client to eigen #423

merged 20 commits into from
Jun 5, 2025

Conversation

juan518munoz
Copy link

What ❔

Why ❔

Is this a breaking change?

  • Yes
  • No

Operational changes

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025 •
edited
Loading

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(eth_sender): Support new transaction type
  • fix(state_keeper): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

Unknown release type "Fix" found in pull request title "Fix: Rename eigenda client to eigen". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

gianbelinche
gianbelinche reviewed Jun 4, 2025
View reviewed changes
core/node/da_clients/src/eigen_da/EIGENDAV2_MIGRATION.md Outdated
Comment on lines 51 to 56

```yaml
da_client:
client: EigenDA
client: Eigen
private_key: <your_private_key>
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed now, it is the same config

@juan518munoz juan518munoz marked this pull request as ready for review June 4, 2025 19:07
gianbelinche
gianbelinche reviewed Jun 4, 2025
View reviewed changes
core/node/da_clients/src/eigen/EIGENDAV2_MIGRATION.md Outdated
Comment on lines 60 to 61
- Be sure that your private key has the needed permissions set on the V2 client.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re add this part

gianbelinche
gianbelinche approved these changes Jun 4, 2025
View reviewed changes
Copy link

@gianbelinche gianbelinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanbono juanbono merged commit 5b422a2 into eigenda-v2-m0 Jun 5, 2025
8 of 24 checks passed
@juanbono juanbono deleted the rename_eigen_client branch June 5, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanbono juanbono juanbono approved these changes

@gianbelinche gianbelinche gianbelinche approved these changes

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juan518munoz @juanbono @gianbelinche