Skip to content

Change of docs for shunts in network data format #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LKuhrmann
Copy link
Contributor

Changed the network data format shunt description from

"gs":<float>,      # Active power withdrawn per voltage p.u.
"bs":<float>,      # Reactive power withdrawn per voltage p.u.

to

"gs":<float>,      # Active power withdrawn at unity voltage (1 p.u.)
"bs":<float>,      # Reactive power injected at unity voltage (1 p.u.)

Reduces the confusion from #978.

Also changed from per voltage p.u. to at unity voltage (1 p.u.) as the current phrasing implies a false linearity with voltage (it is quadratic).

Copy link

codecov bot commented Jul 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.88%. Comparing base (c404096) to head (a885568).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #979   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files          43       43           
  Lines        9654     9654           
=======================================
  Hits         9064     9064           
  Misses        590      590           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c404096...a885568. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LKuhrmann LKuhrmann changed the title Change of network data format shunt comments Change of docs for shunts in network data format Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant