chore/improve tests #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
laurigates
commented
Jun 22, 2025
laurigates
commented
- fix: improve test suite reliability and mocking
- docs: add FoundryVTT API reference link to CLAUDE.md
- Fix axios mocking in FoundryClient tests by adding proper interceptors mock - Add apiKey to test client configurations to enable API calls - Fix header expectations in constructor tests to match actual implementation - Add axios mocking setup to integration tests - Format README.md with consistent spacing - Improve test success rate from 51/72 to 58/72 tests passing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add null checks for undefined XP values in level progression - Fix restoreResources method implementation with proper return statement - Use resetType property instead of non-existent restore flags - Handle resource restoration for both short and long rests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add null checks for currentCombatant assignment - Provide default values for optional combatant properties - Fix initiative and AC to use numbers instead of undefined - Add safety checks for array access in time calculations - Handle undefined combatant states properly 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add default timeout value for axios configuration - Fix DiceRoll interface compliance with exactOptionalPropertyTypes - Handle optional reason property correctly in dice roll results - Add null checks for dice parsing parameters - Ensure DiceRoll objects match interface requirements exactly 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add default values for optional configuration properties - Fix private config access with type assertions - Add explicit type annotations for implicit any parameters - Handle undefined array access with proper index signatures - Improve pickRandom method with proper error handling - Fix resource URI parameter handling 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.