feat: implement real integration testing with FoundryVTT containers #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurigates
had a problem deploying
to
auto-approved
GitHub Actions
Failure
laurigates
force-pushed
the
feat/real-integration-testing
branch
from
9c681b0 to
a80c0dc
Compare
laurigates
had a problem deploying
to
auto-approved
GitHub Actions
Failure
Replace mock-heavy integration tests with real FoundryVTT instances using testcontainers and felddy/foundryvtt-docker. This addresses critical test quality issues identified in the existing test suite. Features: - Real FoundryVTT container integration via testcontainers - GitHub Actions CI/CD with Docker services - Contract testing to validate API response schemas - Authentication and WebSocket testing with real instances - Comprehensive error scenario coverage - Security-conscious fork PR handling with manual approval Technical Implementation: - Added testcontainers dependency for programmatic container management - Created vitest.integration.config.ts for integration test configuration - Implemented docker-compose.test.yml using proven community container - Added credential management templates for secure testing - Created comprehensive integration test suite in tests/integration/ - Added GitHub Actions workflow with real FoundryVTT services This replaces implementation detail testing with behavior validation, ensuring tests verify actual FoundryVTT integration rather than mock responses. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
laurigates
force-pushed
the
feat/real-integration-testing
branch
from
a80c0dc to
39bf30d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces mock-heavy integration tests with real FoundryVTT instances using testcontainers and the proven
felddy/foundryvtt-dockercontainer. This addresses critical test quality issues where tests were validating implementation details rather than actual behavior.Key Improvements
🔄 From Mock-Heavy to Real Testing
🛠 Technical Implementation
Test Coverage
Usage
Files Added/Modified
/tests/integration/- Real FoundryVTT testingvitest.integration.config.ts,docker-compose.test.yml.github/workflows/integration.ymlThis implementation provides the foundation for reliable, behavior-focused testing that validates actual FoundryVTT integration rather than mock configurations.
🤖 Generated with Claude Code