add back drmp3 as an alternative backend to minimp3 #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madebr
reviewed
Mar 9, 2025
|
We should leave SDL2 alone. Again, wait for @icculus to chime in before merging this please. |
|
Merge all the decoder things, this is the time to do it. Also, there's probably no reason to keep minimp3. |
OK, will do so soon. Note: Merging #673 beforehand will free me of conflict-resolving this one. |
sezero
force-pushed
the
drmp3-test3
branch
2 times, most recently
from
4fe467c to
2d021e0
Compare
|
OK, removed minimp3 as a mp3 backend now. Noticed a duration issue though and reported at the mainstream ticket, but I guess it can be resolved soon. |
|
Please wait for the duration issue to be resolved before merging. |
madebr
reviewed
Mar 10, 2025
|
I think this should be good now. |
|
This is in now |
Done: 767fedc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dr_mp3 seems to have solved the Xing/Info tags parsing and duration issues (mackron/dr_libs#263, also see #439), so here it is.
Minimp3 is still the default.
I have a similar patch for SDL2 branch: Should I make a PR, or should we let SDL2 as is?