Skip to content

cmake: add current directory to module search path in installed config file #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Apr 8, 2025

No description provided.

@sezero
Copy link
Contributor

sezero commented Apr 8, 2025

Looks like this solves the 'Linux (CMake, static)' workflow failing
at 'verify cmake configuration files' step, because it couldn't find
PkgConfigHelper.cmake: you're still not installing those cmake stuff
in static builds but it now succeeds?

In any case, is this relevant in other satellite libs?

@madebr
Copy link
Contributor Author

madebr commented Apr 8, 2025

Looks like this solves the 'Linux (CMake, static)' workflow failing at 'verify cmake configuration files' step, because it couldn't find PkgConfigHelper.cmake: you're still not installing those cmake stuff in static builds but it now succeeds?

We were installing it, but we are including it without an absolute path, so we need to add the current directory to the module path.

We have to modify the module search path anyways, otherwise the various find_package's would fail finding our custom FindXXX.cmake modules.

In any case, is this relevant in other satellite libs?

I did a search and we correctly modify CMAKE_MODULE_PATH in other SDL2 projects.

@sezero sezero merged commit 141b69c into libsdl-org:SDL2 Apr 8, 2025
8 checks passed
@sezero
Copy link
Contributor

sezero commented Apr 8, 2025

OK then, it's in.

@madebr madebr deleted the heads/cmake-add-to-module-path branch April 8, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants