Changed frames/ms types from Uint64 to Sint64 #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary so that the behavior is the same as when the return value was 0 on error.
I was thinking about this, too...but let's merge this for now and we can consider that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first draft for converting the parameter types of of
frames/msfor the conversion functions and theMIX_SetTrackPlaybackPosition()function fromUint64toSint64.Conversion functions now return
-1on error and set a message.Negative
frame/msarguments are not allowed.TODO:
Comments could use a little more tweaking.
Maybe?:
Allow converting negative
frames/msso that negative return values can be used in arithmetic expressions? (return value on error would then be 0 again)Closes #711