Fixed bug #733: build error on android with NEON intrinsics #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neon intrinsics "vcopyq_laneq_f32" is undeclared. It is defined in <arm_neon.h>, but not activated because of __ARM_FP value. So, unactivate NEON intrinsics for spatialization on Android.
|
Without this patch, does it still fail when targeting arm64 ?? |
|
@sezero |
|
So, add an additional restriction for arm64, e.g. something like this ??? #if defined(SDL_PLATFORM_ANDROID) && defined(SDL_NEON_INTRINSICS) && !defined(__aarch64__)
|
|
@sezero |
You're welcome
Yes please. Otherwise, it would be sad to disable neon for aarch64. |
|
Committed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neon intrinsics "vcopyq_laneq_f32" is undeclared.
It is defined in <arm_neon.h>, but not activated because of __ARM_FP value.
So, unactivate NEON intrinsics for spatialization on Android.