fix: ensure filter is also an acceptable size #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the lack of response, I'll try to take a closer look soon. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering currently panics for SVGs with extremely large filters, like https://github.com/Davidoc26/wallpaper-selector/blob/main/data/icons/io.github.davidoc26.wallpaper_selector.svg.
I am not terribly familiar with this project, but it seems that while the layer will be shrunk if it is too large, the filters are left unchanged, which eventually causes a source / dest size mismatch and panics when they are asserted to be the same. This change shrinks the filter via the transform as well, if necessary, which resolves the issue when I test it and matches the correct rendering.