Improve the test harness #954
Open
+178
−203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it really awkward to work with the test harness (generating new reference images, generating diff images, etc.), so I've rewritten it a bit to be more similiar to how we have it in vello_cpu.
First, in case a test fails it now prints a nice diff image that also shows the expected and actual versions on the left/right:
In case you want to override the tests that are currently failing, you can run with
MAKE_REF="" cargo test --releaseto do so.I've raised the pixel diff threshold to 1 because it seems like there are apparently slight differences when loading with the
imagecrate vs. the previous code, not sure if we should set this to 0 and re-add the previously existing code instead.Overall, this will hopefully make it easier to work with the test suite. :)