Skip to content

Fix schemasheet just recipe and the parameters it uses #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix schemasheet just recipe and the parameters it uses #43

wants to merge 1 commit into from

Conversation

MirjamSchr
Copy link
Contributor

This was the first step to get the just setup command running.

@dalito
Copy link
Member

dalito commented Feb 13, 2025

Yes, I know. Unfortunately you hit the wrong moment to try. This is fixed but better wait for 0.2.0 to try.

Running just recursively has some disadvantages that I like to avoid.

@MirjamSchr
Copy link
Contributor Author

MirjamSchr commented Feb 13, 2025

Now it is able to run completely.

@dalito
Copy link
Member

dalito commented Feb 13, 2025

@MirjamSchr Thanks for looking into the issue.

It was solved by splitting the setup recipe into two and by specifying for the second _setup_part2 that it should run last (with &&, see here).

@dalito dalito closed this Feb 13, 2025
@dalito dalito reopened this Feb 14, 2025
@dalito
Copy link
Member

dalito commented Feb 14, 2025

Yesterday, I did not see the schemasheet related changes added later. It would be good to get these in. I changed all yes/no questions to bool but forgot to also update the schemasheet recipe (I never use it).

Can you rebase the PR to resolved conflicts?

@dalito dalito added this to the Release 0.2.1 milestone Feb 14, 2025
@dalito dalito changed the title Adjust justfile to run just commands in the middle of a recipe. Fix schemasheet recipe in just Feb 14, 2025
@dalito dalito changed the title Fix schemasheet recipe in just Fix schemasheet just recipe and the parameters it uses Feb 14, 2025
@@ -136,7 +136,7 @@ _update-linkml:
poetry add -D linkml@latest

_compile_sheets:
@if [ "{{use_schemasheets}}" != "No" ]; then \
@if [ "{{use_schemasheets}}" != "False" ]; then \
Copy link
Member

@dalito dalito Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be slightly better to check for "True" to not run on misspelled words.

    @if [ {{use_schemasheets}} == "True" ]; then \

# Conflicts:
#	template/justfile
@MirjamSchr
Copy link
Contributor Author

Eventuall, here is the update.

@dalito
Copy link
Member

dalito commented Feb 15, 2025

This is no longer required due to #46 / #48.

@dalito dalito closed this Feb 15, 2025
@dalito dalito removed this from the Release 0.2.1 milestone Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants