-
Notifications
You must be signed in to change notification settings - Fork 4
Fix schemasheet just recipe and the parameters it uses #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yes, I know. Unfortunately you hit the wrong moment to try. This is fixed but better wait for 0.2.0 to try. Running just recursively has some disadvantages that I like to avoid. |
Now it is able to run completely. |
@MirjamSchr Thanks for looking into the issue. It was solved by splitting the |
Yesterday, I did not see the schemasheet related changes added later. It would be good to get these in. I changed all yes/no questions to bool but forgot to also update the schemasheet recipe (I never use it). Can you rebase the PR to resolved conflicts? |
template/justfile
Outdated
@@ -136,7 +136,7 @@ _update-linkml: | |||
poetry add -D linkml@latest | |||
|
|||
_compile_sheets: | |||
@if [ "{{use_schemasheets}}" != "No" ]; then \ | |||
@if [ "{{use_schemasheets}}" != "False" ]; then \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be slightly better to check for "True" to not run on misspelled words.
@if [ {{use_schemasheets}} == "True" ]; then \
# Conflicts: # template/justfile
Eventuall, here is the update. |
This was the first step to get the
just setup
command running.