-
Notifications
You must be signed in to change notification settings - Fork 33
Convert test_rdflib_dumper.py from unittest to pytest #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert test_rdflib_dumper.py from unittest to pytest #427
Conversation
vladistan
commented
Aug 1, 2025
- Convert setUp methods to pytest fixtures (prefix_map, converter_prefix_map, issue_429_graph)
- Convert all 13 test methods from 2 classes to standalone functions
- Convert _check_objs from instance method to helper function
930da34
to
586ec7c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
==========================================
- Coverage 77.45% 77.38% -0.07%
==========================================
Files 52 52
Lines 4479 4479
Branches 979 979
==========================================
- Hits 3469 3466 -3
- Misses 783 785 +2
- Partials 227 228 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a1b6198
to
0dbb217
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the cruft; using pytest's parametrize
to run the same test with different inputs.
0dbb217
to
64b5168
Compare
- Convert setUp methods to pytest fixtures (prefix_map, converter_prefix_map, issue_429_graph) - Convert all 13 test methods from 2 classes to standalone functions - Convert _check_objs from instance method to helper function
d5d2b34
to
8a9e585
Compare
@ialarmedalien - I'd like to get this into the release candidate today - is your review still blocking here? |
Nope, sorry for the delay in re-reviewing! |