Skip to content

Convert test_rdflib_dumper.py from unittest to pytest #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vladistan
Copy link
Contributor

  • Convert setUp methods to pytest fixtures (prefix_map, converter_prefix_map, issue_429_graph)
  • Convert all 13 test methods from 2 classes to standalone functions
  • Convert _check_objs from instance method to helper function

@vladistan vladistan force-pushed the convert-test-rdflib-dumper-to-pytest branch from 930da34 to 586ec7c Compare August 1, 2025 16:40
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.38%. Comparing base (c5bec6e) to head (1571cf8).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   77.45%   77.38%   -0.07%     
==========================================
  Files          52       52              
  Lines        4479     4479              
  Branches      979      979              
==========================================
- Hits         3469     3466       -3     
- Misses        783      785       +2     
- Partials      227      228       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vladistan vladistan force-pushed the convert-test-rdflib-dumper-to-pytest branch from a1b6198 to 0dbb217 Compare August 2, 2025 14:02
@vladistan vladistan marked this pull request as ready for review August 3, 2025 23:25
Copy link
Collaborator

@ialarmedalien ialarmedalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the cruft; using pytest's parametrize to run the same test with different inputs.

@vladistan vladistan force-pushed the convert-test-rdflib-dumper-to-pytest branch from 0dbb217 to 64b5168 Compare August 4, 2025 21:19
- Convert setUp methods to pytest fixtures (prefix_map, converter_prefix_map, issue_429_graph)
- Convert all 13 test methods from 2 classes to standalone functions
- Convert _check_objs from instance method to helper function
@vladistan vladistan force-pushed the convert-test-rdflib-dumper-to-pytest branch from d5d2b34 to 8a9e585 Compare August 5, 2025 01:15
@vladistan vladistan requested a review from ialarmedalien August 5, 2025 01:19
@sierra-moxon
Copy link
Member

@ialarmedalien - I'd like to get this into the release candidate today - is your review still blocking here?

@ialarmedalien
Copy link
Collaborator

Nope, sorry for the delay in re-reviewing!

@sierra-moxon sierra-moxon merged commit e3d1ed5 into linkml:main Aug 11, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants