[fix]: handle 429 and 002 errors during linodemachine creation #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulait
commented
Jul 9, 2024
rahulait
commented
Jul 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
- Coverage 66.06% 65.99% -0.08%
==========================================
Files 42 42
Lines 2620 2623 +3
==========================================
Hits 1731 1731
- Misses 794 796 +2
- Partials 95 96 +1 ☔ View full report in Codecov by Sentry. |
rahulait
force-pushed
the
handle-api-errors
branch
2 times, most recently
from
f6c015e to
30501b6
Compare
rahulait
force-pushed
the
handle-api-errors
branch
2 times, most recently
from
4a85dfd to
7d89ca2
Compare
AshleyDumaine
previously approved these changes
Jul 10, 2024
rahulait
force-pushed
the
handle-api-errors
branch
from
ada06ac to
03211de
Compare
eljohnson92
approved these changes
Jul 10, 2024
eljohnson92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If too many requests are made to linodeAPI in a short span of time, it returns 429 error. This PR handles 429 errors and makes sure we retry creating machine after some time. Similarly, if there is client timeout or unexpected EOF errors, we get 002 as returncode. This PR handles those errors as well.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: