Skip to content

[feat] add controller concurrency options with elevated defaults #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

eljohnson92
Copy link
Collaborator

What this PR does / why we need it:
Adds options to configure controller concurrency and QPS/Burst values to the kube API server
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@eljohnson92 eljohnson92 force-pushed the add_controller_concurrency branch 5 times, most recently from cd38a2a to 4832efc Compare July 10, 2024 19:29
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 66.06%. Comparing base (51681b7) to head (b670bdb).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/main.go 0.00% 31 Missing ⚠️
controller/linodecluster_controller.go 0.00% 2 Missing ⚠️
controller/linodemachine_controller.go 0.00% 2 Missing ⚠️
controller/linodeobjectstoragebucket_controller.go 0.00% 2 Missing ⚠️
controller/linodevpc_controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   66.58%   66.06%   -0.53%     
==========================================
  Files          42       42              
  Lines        2583     2620      +37     
==========================================
+ Hits         1720     1731      +11     
- Misses        768      794      +26     
  Partials       95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eljohnson92 eljohnson92 force-pushed the add_controller_concurrency branch from 4832efc to bff6549 Compare July 10, 2024 20:02
@eljohnson92 eljohnson92 force-pushed the add_controller_concurrency branch from bff6549 to b670bdb Compare July 10, 2024 20:27
@eljohnson92 eljohnson92 merged commit 31917b5 into main Jul 10, 2024
10 of 12 checks passed
@eljohnson92 eljohnson92 deleted the add_controller_concurrency branch July 10, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants