Skip to content

[fix] create ipv6/AAAA records only for dualstack flavors #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

amold1
Copy link
Contributor

@amold1 amold1 commented Jul 11, 2024

What this PR does / why we need it:
We should only create AAAA records for dual-stack flavors and not all dns flavors. Currently we create A and AAAA records for all nodes for all dns based loadbalancing flavors.(a linode by default has one IPv4 and one IPv6 IP regardless of flavor)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.04%. Comparing base (cc56907) to head (636163c).

Files Patch % Lines
cloud/services/domains.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   66.10%   66.04%   -0.07%     
==========================================
  Files          42       42              
  Lines        2623     2624       +1     
==========================================
- Hits         1734     1733       -1     
- Misses        794      795       +1     
- Partials       95       96       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amold1 amold1 marked this pull request as draft July 11, 2024 16:24
@amold1 amold1 closed this Jul 11, 2024
@amold1 amold1 deleted the ipv6.labeler branch August 7, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant