-
Notifications
You must be signed in to change notification settings - Fork 28
[feat] Add support for new network interfaces #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ab0b7cf
add support for new network interfaces on LinodeMachines
AshleyDumaine 2d6edae
add some fixes and validation for linode creation with new network in…
AshleyDumaine c4906ae
We cannot configure network helper at all if using the new linode int…
AshleyDumaine f125678
allow skipping of setting interfaces and linodeInterfaces via Interfa…
AshleyDumaine 07e673b
add webhook test
AshleyDumaine 6ed8cd5
fix setting of interfaceGeneration
AshleyDumaine 3f9319b
update with latest commit on proj/vpc-dual-stack linodego branch
AshleyDumaine f6ed3ee
update firewall listing for new linode interfaces
AshleyDumaine 22ba316
flip the conditional check just in case InstanceGeneration doesn't ge…
AshleyDumaine 265d4f0
add some comments and handle network helper
AshleyDumaine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm struggling to parse that. Should that be "...for the cluster's nodes IF interface / linodeInterface are not specified for a LinodeMachine"? If not, I'm not sure what it means. But then again, I don't really know what I'm talking about in this domain...
Feel free to resolve this comment into oblivion.