Skip to content

[CIR][NFC] Teach op parsers to use enum keyword parsing helpers #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

[CIR][NFC] Teach op parsers to use enum keyword parsing helpers #1298

merged 1 commit into from
Jan 29, 2025

Conversation

AmrDeveloper
Copy link
Member

Change parseVisibilityAttr to use enum parser helper parseOptionalCIRKeyword

Fixes: #770

@bcardosolopes
Copy link
Member

We just went over a rebase against upstream, apologies for the churn but please update your branch for this PR and force-push!

@bcardosolopes bcardosolopes changed the title [CIR] Teach op parsers to use enum keyword parsing helpers [CIR][NFC] Teach op parsers to use enum keyword parsing helpers Jan 29, 2025
bcardosolopes
bcardosolopes approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@bcardosolopes bcardosolopes merged commit a310ae0 into llvm:main Jan 29, 2025
3 of 6 checks passed
AmrDeveloper added a commit to AmrDeveloper/clangir that referenced this pull request Jan 29, 2025
@AmrDeveloper
[CIR][NFC] Teach op parsers to use enum keyword parsing helpers (llvm…
d77509c 
…#1298)

Change `parseVisibilityAttr` to use enum parser helper
`parseOptionalCIRKeyword`

Fixes: llvm#770
lanza pushed a commit that referenced this pull request Mar 18, 2025
@AmrDeveloper @lanza
[CIR][NFC] Teach op parsers to use enum keyword parsing helpers (#1298)
6fce557 
Change `parseVisibilityAttr` to use enum parser helper
`parseOptionalCIRKeyword`

Fixes: #770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Teach op parsers to use enum keyword parsing helpers
2 participants
@AmrDeveloper @bcardosolopes