-
Notifications
You must be signed in to change notification settings - Fork 162
[CIR][Github][CI] Add clangir upstream rebase workflow #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lanza I believe this does the job. To be secure at the moment it just creates |
It needs to be triggered manually at the moment. I think we can let it run every night then? Before that, we need to setup WORKFLOW_TOKEN to have access to write to repo. |
Yea that makes sense IMO. I don't remember if we talked about this, but I don't think it should actualyl push every night. That would cause unnecessary churn on PRs where they are submitted on day X, we rebase on night X, and thus the PRs broken by the time they are reviewed on day X+1.
But I have no clue how to do either of these things, never really touched github actions. Do you need extra permissions to do this or something? Only change I can think of for the diff would to add an optional |
67b84f2
to
40e59b1
Compare
Finally got back to this. Tests are failing because I modified the generic LLVM workflow, which does not enable CLANGIR but still attempts to run its tests. This shouldn't be an issue when merged. Currently, this needs to be triggered manually. It will create a branch named It's failing on rebase due to merge conflicts, so the next rebase needs to be done manually. However, you can use: sh ./.github/workflows/rebase-clangir-onto-llvm-upstream.sh rebased-main --checked to start the rebase locally. (Note. The |
Okay I'll kick off a rebase over the next few days.
I guess there's a level of permissions only Tom Stellard can grant? So yea, I have no idea what to do for that :p |
Ok I will merge it then, and let us first see whether the script works locally for you :) |
No description provided.