Skip to content

[CIR] Fix Global Ctor/Dtor priority attributes #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

[CIR] Fix Global Ctor/Dtor priority attributes #1743

merged 1 commit into from
Jul 14, 2025

Conversation

xlauko
Copy link
Collaborator

@xlauko xlauko commented Jul 14, 2025 •
edited
Loading

  • This fixes default value to be expected 65535
  • Introduces DefaultGlobalCtorDtorPriority constant
  • Makes function to use I32Attr for priority instead of unnecessary attribute with reference to function

@xlauko
Copy link
Collaborator Author

xlauko commented Jul 14, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@xlauko xlauko marked this pull request as ready for review July 14, 2025 14:34
@xlauko xlauko force-pushed the users/xlauko/cir-ctor-dtor-attrs branch from c614f1f to c3066b8 Compare July 14, 2025 14:38
bcardosolopes
bcardosolopes approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@xlauko
[CIR] Fix Global Ctor/Dtor priority attributes
f8bce5f 
- This fixes default value to be expected 65535
- Makes function use I32Attr for priority instead of unnecessary attribute with reference to function
@xlauko xlauko force-pushed the users/xlauko/cir-ctor-dtor-attrs branch from c3066b8 to f8bce5f Compare July 14, 2025 21:01
@xlauko xlauko merged commit ee785a0 into main Jul 14, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xlauko @bcardosolopes