Skip to content

[CIR][CodeGen] Implemented CIR generation for CXXPseudoDestructorExpr #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025

Conversation

tommymcm
Copy link
Contributor

Implemented CIR code generation for CXXPseudoDestructorExpr.
Added a pseudo destructor test to CIR/CodeGen/dtors.cpp.

@lanza lanza force-pushed the main branch 2 times, most recently from d2c4ab8 to 8f89224 Compare July 23, 2025 17:04
Implemented CIR code generation for `CXXPseudoDestructorExpr`.
Added a pseudo destructor test to `CIR/CodeGen/dtors.cpp`.
@tommymcm tommymcm force-pushed the pseudo-destructor-expr branch from a22b940 to 040e944 Compare July 23, 2025 18:01
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you later check if this can be upstreameable as is? If so might be worth putting a PR to the llvm-project

@bcardosolopes bcardosolopes merged commit d423af4 into llvm:main Jul 28, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants