[CIR][CodeGen] Attach hot attribute to CIR function #1826
Conversation
rafasumi
requested review from
lanza,
bcardosolopes,
xlauko and
andykaylor
as code owners
rafasumi
changed the title
| llvm::ConstantAsMetadata::get( | ||
| llvm::ConstantInt::get(int32Ty, openclVersionAttr.getMajorVersion())), | ||
| llvm::ConstantAsMetadata::get( | ||
| llvm::ConstantInt::get(int32Ty, openclVersionAttr.getMinorVersion()))}; | ||
| llvm::ConstantAsMetadata::get(llvm::ConstantInt::get( | ||
| int32Ty, openclVersionAttr.getMajorVersion())), | ||
| llvm::ConstantAsMetadata::get(llvm::ConstantInt::get( | ||
| int32Ty, openclVersionAttr.getMinorVersion()))}; |
There was a problem hiding this comment.
This change was made by clang-format when I ran it for this file. I can revert it if you prefer.
There was a problem hiding this comment.
If you could revert so blame doesn't get messed up that'd be great.
clang/test/CIR/CodeGen/hot-attr.cpp
Outdated
| } | ||
|
|
||
| // CIR: #fn_attr = #cir<extra({hot = #cir.hot, nothrow = #cir.nothrow})> | ||
| // CIR: cir.func dso_local @_Z2s0ii(%arg0:{{.*}}, %arg1:{{.*}} -> {{.*}} extra(#fn_attr) |
There was a problem hiding this comment.
Can you refractor this so that it doesn't include hard coded names like %arg0 and %arg1.
There was a problem hiding this comment.
I made some changes to the test to make it depend less on unrelated identifiers. I tried using mlir/utils/generate_test_checks.py, but I think the result was also a bit hard-coded. This is a great script though, thanks for the tip.
There was a problem hiding this comment.
I usually use generated checks as a starting point, then remove parts and rename variables to reflect the soul of the test.
clang/test/CIR/CodeGen/hot-attr.cpp
Outdated
| } | ||
|
|
||
| // CIR: #fn_attr = #cir<extra({hot = #cir.hot, nothrow = #cir.nothrow})> | ||
| // CIR: cir.func dso_local @_Z2s0ii(%arg0:{{.*}}, %arg1:{{.*}} -> {{.*}} extra(#fn_attr) |
There was a problem hiding this comment.
Also break it up so that each part of the check is on a different comment line using CIR-SAME
There was a problem hiding this comment.
I've removed arguments from the check, so maybe this is less necessary. However, I’ve split it into two checks either way.
Implemented missing feature for issue #1793. Also implemented LLVM lowering for the hot attribute, and added a new test case.