[CIR][CIRGen] Add CIRGen for scalar co_yield expression #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
LGTM after minor comment.
BTW, if you have more plans to work on coroutines, please let me know, I've been planning to tackle it (lowering) once I'm done with exceptions, but if you are planning to put work there I'm happy to yield (no pun intended) and give you some brain dump.
Excellent! I'd love to help with the coroutines part if you don't get enough bandwidth for that! |
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
This PR adds CIRGen for scalar `co_yield` expressions.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
This PR adds CIRGen for scalar `co_yield` expressions.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
This PR adds CIRGen for scalar `co_yield` expressions.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
This PR adds CIRGen for scalar `co_yield` expressions.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
This PR adds CIRGen for scalar `co_yield` expressions.
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
This PR adds CIRGen for scalar `co_yield` expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CIRGen for scalar
co_yieldexpressions.