Add Lucide Icons support for Button and Icon components (#77) #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create LucideIcon enum with 150+ predefined icons for type safety - Add dedicated Icon component for standalone icon usage with size presets - Update SystemImage to auto-detect and render Lucide vs system icons - Enhance Button component with direct LucideIcon support - Add LucideStyles utility for CSS management (CDN/local options) - Include comprehensive test suite covering all functionality - Maintain backward compatibility with existing SystemImage usage - Support accessibility features with automatic ARIA labels
…ines refactor - Merge Lucide Icons functionality with updated naming conventions - Preserve type-safe LucideIcon enum and auto-detection logic - Update SystemImage to use buildMarkupTag() method naming - Maintain <i> tag for Lucide icons, <span> for system icons - Ensure all Lucide functionality works with latest API changes
maclong9
added a commit
that referenced
this pull request
Jul 7, 2025
…#83) - Create LucideIcon enum with 150+ predefined icons for type safety - Add dedicated Icon component for standalone icon usage with size presets - Update SystemImage to auto-detect and render Lucide vs system icons - Enhance Button component with direct LucideIcon support - Add LucideStyles utility for CSS management (CDN/local options) - Include comprehensive test suite covering all functionality - Maintain backward compatibility with existing SystemImage usage - Support accessibility features with automatic ARIA labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
Technical Details
<i>tags for Lucide icons vs<span>for system iconslucide lucide-{icon-name}Test Coverage
All 394 tests passing, including 27 new Lucide-specific tests covering:
Breaking Changes
None - maintains full backward compatibility
Closes #77