Skip to content

feat: Add clean command to dev.sh script #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

iNem0o
Copy link
Contributor

@iNem0o iNem0o commented Nov 1, 2024

Hello

This PR add a new development helper command to completely clean up the Docker environment. This is useful for contributors who want to reset their development environment to a clean state.

The clean command performs the following:

  • Stops and removes all containers
  • Removes all Docker images used by the project
  • Removes all associated volumes
  • Cleans up any orphaned containers

Usage:

./dev.sh clean

Documentation has been adjusted accordingly to the change.

Copy link
Member

@SimonMellerin SimonMellerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR, it's nice to see people use this dev tool and improve it!

Copy link
Member

@SimonMellerin SimonMellerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pounard may be you want to review this one

@pounard
Copy link
Member

pounard commented Nov 5, 2024

It seems all good to me!

Pipeline is green, so let's merge this.

@pounard pounard merged commit 8609b82 into makinacorpus:main Nov 5, 2024
1 check passed
@pounard
Copy link
Member

pounard commented Nov 5, 2024

@iNem0o thanks!

@pounard
Copy link
Member

pounard commented Nov 5, 2024

It lack a line in the changelog, we'll have to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants