Skip to content

Allow a Separate High Angle Bank Scale Factor to Be Defined in User File #39806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

cailafinn
Copy link
Contributor

Description of work

Adds the option to supply a front_scale value in the user file. This overrides a value given to rear_scale to be applied to the HAB workspaces.

Note: This PR modifies SANS TOML V1. Given that this parameter was already mentioned in the documentation for TOML V1 but didn't do anything, the decision was made to update the old format rather than updating

Also fixes a test class for the beam centre finder that wasn't in the CMakeLists.txt file and so wasn't being run.

Closes #39341
Closes #27948

To test:

  1. Make a copy of the MaskFile.toml User file from the loqdemo.
  2. In this copy, add a front_scale value to the [detector.configuration] section.
  3. Launch workbench and open the ISIS SANS GUI
  4. Load the original MaskFile.toml and batch_mode_reduction.csv files.
  5. On the second_time run, enter the path to the front_scale copy into the User File box in the grid.
  6. Run Everything
  7. Plot the output files for the HAB and LAB onto separate plots for one of the runs
  8. Drag over the workspaces for the other run to overplot them
  9. Check that the LAB curves are the same and the HAB curve is using the scale you provided in the user file.

Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

@cailafinn cailafinn added this to the Release 6.14 milestone Aug 7, 2025
@cailafinn cailafinn added SANS Issues and pull requests related to SANS ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions labels Aug 7, 2025
@cailafinn cailafinn marked this pull request as ready for review August 8, 2025 09:03
@MialLewis MialLewis self-assigned this Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions SANS Issues and pull requests related to SANS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scale factor for high angle LOQ detector bank LOQ Not Applying Bank by Bank Scaling
2 participants