Allow a Separate High Angle Bank Scale Factor to Be Defined in User File #39806
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Adds the option to supply a
front_scale
value in the user file. This overrides a value given torear_scale
to be applied to the HAB workspaces.Note: This PR modifies SANS TOML V1. Given that this parameter was already mentioned in the documentation for TOML V1 but didn't do anything, the decision was made to update the old format rather than updating
Also fixes a test class for the beam centre finder that wasn't in the CMakeLists.txt file and so wasn't being run.
Closes #39341
Closes #27948
To test:
MaskFile.toml
User file from theloqdemo
.front_scale
value to the[detector.configuration]
section.MaskFile.toml
andbatch_mode_reduction.csv
files.second_time
run, enter the path to thefront_scale
copy into theUser File
box in the grid.Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
Gatekeeper
As per the gatekeeping guidelines: