Skip to content

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jul 3, 2025

Description

  • Htmlparser2 is being used by marko run static adaptor but its being provided by marko/vite (ideally this should be a dependency of this). htmlparsre2 updated its paths in version 10, but version 9 is being used here. When upgrading marko/vite to the latest it breaks.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@agliga agliga requested a review from rturnq July 3, 2025 00:03
Copy link

changeset-bot bot commented Jul 3, 2025

🦋 Changeset detected

Latest commit: 7a400e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@marko/run-adapter-static Patch
@marko/run Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

linux-foundation-easycla bot commented Jul 3, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: agliga / name: Andrew Gliga (b69626d)
  • ✅ login: rturnq / name: Ryan Turnquist (7a400e9)

@agliga agliga force-pushed the adaptor-lib-fix branch from e792576 to b69626d Compare July 3, 2025 00:03
@rturnq rturnq merged commit aa00877 into main Jul 3, 2025
7 checks passed
@rturnq rturnq deleted the adaptor-lib-fix branch July 3, 2025 01:00
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (98595f0) to head (7a400e9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #152   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants