Loosen requests lower pin, fix pre-commit errors
#4469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/Users/yang/developer/pmg/tests/analysis/test_interface_reactions.py:367:
DeprecationWarning: Arrays of 2-dimensional vectors are deprecated. Use
arrays of 3-dimensional vectors instead. (deprecated in NumPy 2.0)
positions = [np.cross(v1, v2) for v1, v2 in relative_vectors]
/Users/yang/developer/pmg/src/pymatgen/core/tensors.py:292: DeprecationWarning: __array_wrap__ must accept context and return_scalar arguments (positionally) in the future. (Deprecated NumPy 2.0)
DanielYang59
force-pushed
the
loosen-requests-dep
branch
from
81fdfb8 to
6283519
Compare
DanielYang59
force-pushed
the
loosen-requests-dep
branch
from
92a36ea to
591186a
Compare
src/pymatgen/io/jdftx/outputs.py:328:45: SyntaxError: Cannot use star expression in index on Python 3.10 (syntax was added in Python 3.11)
DanielYang59
changed the title
requests lower pinrequests lower pin, fix some pre-commit errors
DanielYang59
force-pushed
the
loosen-requests-dep
branch
from
93ea513 to
6de4d95
Compare
DanielYang59
changed the title
requests lower pin, fix some pre-commit errorsrequests lower pin, fix pre-commit errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
requestsupper pin, current pin seems too strict and might cause unresolvable dependencyrufferrors frompre-commit