Move JDFTx sets from atomate2 to pymatgen #4479
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition of JDFTx set to pymatgen from atomate2.
This was referenced Aug 13, 2025
Signed-off-by: Cooper <101949243+cote3804@users.noreply.github.com>
None type handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a request by @utf in an atomate2 PR, I am moving our input set from atomate2 to pymatgen.
This PR adds a
sets.pyfile with one new class,JdftxInputSet, which does little more than wrap the other JDFTx I/o classes. The only minor change to the original atomate2 code is that the__init__method now accepts a pymatgenStructureinstead of aJDFTXStructure.A yaml defining the base input set,
BaseJdftxSet.yamlwas also moved from atomate2.I added two basic tests to check that both loading from an input file and from a
JdftxInfileare working and that the file written by the input set yields the expectedJdftxInfile.