Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Fix EW crashing on incoming call (audio is undefined) #12736

Closed
wants to merge 1 commit into from

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Jul 8, 2024

EW was crashing whenever there was an incoming call.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@toger5 toger5 requested a review from a team as a code owner July 8, 2024 07:07
@toger5 toger5 requested review from MidhunSureshR and robintown July 8, 2024 07:07
@toger5 toger5 added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Jul 8, 2024
@toger5 toger5 changed the title Fix ec crashing on incoming call (audio is undefined) Fix EW crashing on incoming call (audio is undefined) Jul 8, 2024
@toger5 toger5 force-pushed the toger5/fix-ec-crash-on-incoming-call branch from 1b2f2e8 to 6c9b8ac Compare July 8, 2024 08:27
@t3chguy
Copy link
Member

t3chguy commented Jul 8, 2024

Ah balls, looks like the move to AudioContext API missed a bit, this is not the right solution however. I will take it on as maintainer

@toger5
Copy link
Contributor Author

toger5 commented Jul 8, 2024

Oh thanks @t3chguy.
I was not sure if I overlooked this at some point in time.

Thanks for doing this properly.

@toger5 toger5 closed this Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants