Skip to content

🐛 fix(docs): Fix emoji rendering on Firefox #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 22, 2025

Conversation

theogiraudet
Copy link
Contributor

Description

Related Issues

Additional Notes

Tasks to complete before merging

  • I agree to release my contribution under the MPL v2 License.
  • My pull request is associated with an existing issue.
  • I have updated the changelog to reflect my contribution.
  • If this pull request adds or modifies a feature:
    • I have documented my changes in the /docs folder.
    • I have updated the metadata of the feature. See feature metadata.
    • I have thoroughly tested my changes. See testing guidelines.

@theogiraudet
Copy link
Contributor Author

@Stoupy could you check in your own browser to see if the bug is fixed?

@theogiraudet theogiraudet added 🐛 Bug Something isn't working 📝 Documentation Changes or additions to documentation labels Jul 19, 2025
@theogiraudet theogiraudet linked an issue Jul 19, 2025 that may be closed by this pull request
@theogiraudet theogiraudet requested a review from Copilot July 19, 2025 10:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes emoji rendering issues on Firefox by changing the font source from TTF to OTF format. Firefox has better compatibility with OpenType fonts for emoji rendering compared to TrueType fonts.

  • Changes the TossFace font source from tossface.ttf to tossface.otf

Copy link
Member

@aksiome aksiome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use woff instead of ttf since it's better optimized for the web

@theogiraudet theogiraudet requested a review from aksiome July 22, 2025 21:02
@theogiraudet theogiraudet merged commit 01dfb6b into mcbookshelf:master Jul 22, 2025
2 of 3 checks passed
@theogiraudet theogiraudet deleted the doc-emoji-fix branch July 22, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 📝 Documentation Changes or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The documentation doesn't display emojis on Firefox
2 participants