Skip to content

bootutil: Fix PureEdDSA when flash base is not 0x0 #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025

Conversation

nordic-mik7
Copy link
Contributor

@nordic-mik7 nordic-mik7 commented Aug 6, 2025

This commit introduces fix for PureEdDSA signature verification when the flash base address is not 0x0. The issue was that the flash base address was not taken into account when passing the image address to the signature verification function.

Additionally, FLASH_DEVICE_ID for nRF54H20 platform was corrected.

Fixes: #2415

Copy link
Collaborator

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No core and Zephyr specific change in one commit.
Bootutil commits, docs and zephyr get different commits.

@nordic-mik7
Copy link
Contributor Author

No core and Zephyr specific change in one commit. Bootutil commits, docs and zephyr get different commits.

I understand that about Zephyr specific changes and will provide separate commit, but what about docs? Shouldn't release notes update be in the same commit as bugfix in bootutil ?

@nordic-mik7 nordic-mik7 requested a review from de-nordic August 7, 2025 08:37
@de-nordic
Copy link
Collaborator

No core and Zephyr specific change in one commit. Bootutil commits, docs and zephyr get different commits.

I understand that about Zephyr specific changes and will provide separate commit, but what about docs? Shouldn't release notes update be in the same commit as bugfix in bootutil ?

You can make them in one. Up to you.

This commit introduces fix for PureEdDSA signature verification
when the flash base address is not 0x0. The issue was that the
flash base address was not taken into account when passing the
image address to the signature verification function.

Signed-off-by: Michal Kozikowski <michal.kozikowski@nordicsemi.no>
FLASH_DEVICE_ID was incorrectly set to spi related flash id
instead of SoC related.

Signed-off-by: Michal Kozikowski <michal.kozikowski@nordicsemi.no>
@nordic-mik7 nordic-mik7 force-pushed the dev/lillium_pure_signing_up branch from 40ee7cb to 166be07 Compare August 7, 2025 13:34
@nordic-mik7
Copy link
Contributor Author

No core and Zephyr specific change in one commit. Bootutil commits, docs and zephyr get different commits.

I understand that about Zephyr specific changes and will provide separate commit, but what about docs? Shouldn't release notes update be in the same commit as bugfix in bootutil ?

You can make them in one. Up to you.

done

@nordicjm nordicjm merged commit e0b84a0 into mcu-tools:main Aug 13, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signature verification fails when BOOT_SIGNATURE_TYPE_PURE is used and NVM does not start at 0x0
4 participants