Skip to content

Add contact support panel #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Add contact support panel #1292

merged 2 commits into from
Jul 15, 2024

Conversation

marySalvi
Copy link
Collaborator

@marySalvi marySalvi commented Jul 9, 2024

Adds a contact support panel on the DH page and submission list page. Should match the styling in figma.

Closes microbiomedata/user_research#20

@marySalvi marySalvi requested a review from naglepuff July 9, 2024 19:26
Copy link
Collaborator

@naglepuff naglepuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks like its working as intended, I just had one thought about the placement on the submission list.

@naglepuff
Copy link
Collaborator

Also make sure to link the associated issue

@marySalvi
Copy link
Collaborator Author

@mslarae13 Note that I did not include the social media icons at the bottom. I did this for a few reasons:

  1. One of the icons is for emailing and would be redundant of the rest of the component.
  2. The other 3 are brand icons and there are strict rules for each of them
    a. As designed this component doesn't follow those rules.
    b. The icon library we currently use no longer supports brand icons because of these rules and how often they change
    c. From a brief search even icon libraries that do support these icons some (linkedIn) are already deprecated/out of date so they would need to be downloaded individually.
  3. The top 'button' in the component brings a user to the Contact Page which has links for all of these socials so the actions are still available to a user interacting with this component. (Please note that the Contact Page does not follow the rules for there brand icons and this should perhaps be revisited)

Feel free to reach out to me if you have any questions regarding this.

@marySalvi marySalvi requested a review from naglepuff July 15, 2024 14:25
@marySalvi marySalvi merged commit 5047827 into main Jul 15, 2024
2 checks passed
@marySalvi marySalvi deleted the submission_portal-contact-us branch July 15, 2024 15:10
@mslarae13
Copy link
Contributor

@marySalvi did you see @ljohnson09 's comment on the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact info
3 participants