Pass correct string to showColumnsBySectionTitle when showing single section #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1306
Despite its name, DataHarmonizer's
showColumnsBySectionTitlemethod actually expects a section name, and we were passing it a section title.The map that was previously being used to drive the options (
schemaSections) only recorded the section titles. That map has been renamed toschemaSectionColumnssince it is a map from section title to and array of column information. Otherwise it is unchanged and still used in computingfields.To actually fix the bug, these changes add a map (
schemaSectionNames) from section titles (for display) and section names (to pass toshowColumnsBySectionTitle).