Skip to content

Fix DataHarmonizer help sidebar positioning #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

pkalita-lbl
Copy link
Collaborator

Fixes #1304

Description

I think I got a little overzealous with using flexbox layouts in #1267, which resulted in this bug being introduced.

These changes fix the issue by having the help sidebar container be absolutely positioned within its parent element. When toggling the sidebar open/closed a corresponding amount of padding is added to/removed from its sibling element which holds the DataHarmonizer instance. This is so that the sidebar doesn't cover the rightmost columns.

This approach is conceptually similar to the way it worked before #1267 except it uses absolute positioning instead of float. I find float has more unpredictable side effects, so I tend to avoid it.

Testing

Ensure that the help sidebar can be opened and closed while scrolled to any horizontal position in the DataHarmonizer grid. While scrolled all the way to the right, ensure that the final columns can always be accessed.

Copy link
Collaborator

@naglepuff naglepuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this although I do have one observation.

I can't tell if this is a regression (from before the bug being fixed was introduced), but if I am scrolled all the way to the right so that the last column is visible, then opening the sidebar covers up the last column or so. I scroll to the right again, so all columns are still accessible, but there is a weird edge case where a user is scrolled allllll the way over and opens the help sidebar.

I'm fine opening a separate issue to track that if it adds significant complexity to the changes here.

@pkalita-lbl
Copy link
Collaborator Author

pkalita-lbl commented Jul 23, 2024

Yeah I think that's basically the expected behavior and consistent with what it was before #1267. It's kind of analogous to if you were to be scrolled to the bottom of a web page and you made your browser window shorter by using the resize handle on the bottom of the window.

@pkalita-lbl pkalita-lbl merged commit cdab9bc into main Jul 23, 2024
2 checks passed
@pkalita-lbl pkalita-lbl deleted the issue-1304-harmonizer-sidebar-position branch July 23, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: info box expansion is moving to far right
2 participants