Fix DataHarmonizer help sidebar positioning #1310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1304
Description
I think I got a little overzealous with using flexbox layouts in #1267, which resulted in this bug being introduced.
These changes fix the issue by having the help sidebar container be absolutely positioned within its parent element. When toggling the sidebar open/closed a corresponding amount of padding is added to/removed from its sibling element which holds the DataHarmonizer instance. This is so that the sidebar doesn't cover the rightmost columns.
This approach is conceptually similar to the way it worked before #1267 except it uses absolute positioning instead of
float
. I findfloat
has more unpredictable side effects, so I tend to avoid it.Testing
Ensure that the help sidebar can be opened and closed while scrolled to any horizontal position in the DataHarmonizer grid. While scrolled all the way to the right, ensure that the final columns can always be accessed.