Refactor API summary and stats test to be two independent tests #1696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codytodonnell
force-pushed
the
1679-refactor-tests-stats-endpoint
branch
from
f526fc4 to
6388e31
Compare
eecavanna
approved these changes
Jul 16, 2025
eecavanna
changed the title
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_api_summaryfunction was testing two different endpoints together,/api/summaryand/api/stats. This PR separates that test into two. The summary test is also improved now to test both the success of the response and the shape of the data by comparing it to the expectedDatabaseSummaryfields.