Skip to content

Use new association tables for facet counting #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

naglepuff
Copy link
Collaborator

We'll need to take care when joining between omics_processing and workflow tables. Right now we only have a facet for metaproteomics analysis category. As we add more facets, I'd recommend trying to generalize the approach started by this PR.

@naglepuff naglepuff force-pushed the fix-1701-metap-category-facet branch from 5ded759 to 20b656f Compare July 24, 2025 21:59
Base automatically changed from fix-1701-bulk-download-summary to main July 24, 2025 22:00
Copy link
Collaborator

@eecavanna eecavanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes look intentional to me.

@eecavanna eecavanna merged commit e2b738f into main Jul 24, 2025
2 checks passed
@eecavanna eecavanna deleted the fix-1701-metap-category-facet branch July 24, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants