-
Notifications
You must be signed in to change notification settings - Fork 0
Add message to Swagger UI page encouraging visitors to use Runtime API instead #1715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eecavanna
wants to merge
5
commits into
main
Choose a base branch
from
1593-add-message-to-data-portal-swagger-ui-encouraging-visitors-to-use-runtime-api-instead
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−6
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8fa8b8b
Refactor Swagger UI description into HTML template file
eecavanna f4a4e15
Add message encouraging visitors to use Runtime API instead
eecavanna 1cbdb48
Use Markdown instead of HTML (per FastAPI docstring)
eecavanna 251e920
Reformat Python code to match black output
eecavanna 293daba
Remove `r` prefix to make strings easier to read
eecavanna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
from importlib import resources | ||
|
||
|
||
def load_template(resource_path: str) -> str: | ||
r""" | ||
eecavanna marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Returns the contents of a template file as a string. | ||
|
||
Note: We do this via `importlib.resources` instead of a regular `open()` so | ||
that the path is accurate both when this script is run in a development | ||
environment and when this script is run when installed from PyPI, | ||
instead of it only being accurate in the former case. | ||
Reference: https://docs.python.org/3.9/library/importlib.html#importlib.resources.files | ||
|
||
Note: This function was copied from the `refscan` repository, at: | ||
https://github.com/microbiomedata/refscan/blob/a30ece13/refscan/grapher.py#L31-L42 | ||
""" | ||
|
||
package_name = "nmdc_server.swagger_ui.templates" | ||
return resources.files(package_name).joinpath(resource_path).read_text(encoding="utf-8") |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<!-- | ||
Note: The `description` kwarg of the `FastAPI` constructor supports CommonMark syntax, | ||
according to the constructor's docstring. | ||
--> | ||
|
||
This API was designed to be accessed by | ||
the [NMDC Data Portal]({{ nmdc_data_portal_url }}) and | ||
the [NMDC Submission Portal]({{ nmdc_submission_portal_url }}) only. | ||
naglepuff marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
**Want to access NMDC data from your own scripts and programs?** | ||
Check out the [NMDC Runtime API]({{ runtime_api_url }}), which was | ||
designed to be accessed by third-party scripts, programs, and other HTTP clients. | ||
|
||
**NMDC developers:** To use authenticated endpoints of this API, | ||
you must first obtain an Access Token by following the instructions in the | ||
Developer Tools section [here]({{ developer_tools_url }}). | ||
Once you have an Access Token, click the "Authorize" button on this page. | ||
In the popup, paste the token in the "Value" field and click "Authorize". |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these URLs be set as configuration? That way the dev swagger page can link to the dev data portal, etc?