Add search functionality for users table #1718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naglepuff
reviewed
Aug 4, 2025
|
@naglepuff Pushed up your requested changes |
mslarae13
approved these changes
Aug 6, 2025
naglepuff
approved these changes
Aug 6, 2025
|
@naglepuff I think both of your last comments were good and added those. Pushed the changes and will merge once tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1673
New code here adds a search box to the Users page to allow filtering based on name or ORCID.
If something matching the ORCID RE pattern is entered into the box then it will search for that, otherwise it defaults to user name.
@naglepuff I haven't done any real formatting on the search box to make it look nice, I was hoping for an initial bit of feedback on functionality before that. Mostly I was wondering if we wanted something like a toggle button to filter based on admin status.
Examples:
